Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper timezone support #9

Closed
marksteward opened this issue Feb 9, 2015 · 4 comments · Fixed by #18
Closed

Add proper timezone support #9

marksteward opened this issue Feb 9, 2015 · 4 comments · Fixed by #18

Comments

@marksteward
Copy link
Contributor

To be done by 29 March.

Use aware timezones for input data possible, and check that they're not ambiguous:

https://github.com/pubstandards/pubstandards-london/blob/master/tests/test_ps_data.py#L71

Output timezone to the ical, and add the timezone to each event.

@marksteward
Copy link
Contributor Author

WIP on https://github.com/pubstandards/pubstandards-london/tree/timezone_support, and currently running at http://ps.rack.ms/.

Currently doesn't include a VTIMEZONE block, and (perhaps because of that) doesn't seem to load in Google Calendar. works in Google Calendar now.

@marksteward
Copy link
Contributor Author

To do:

@marksteward
Copy link
Contributor Author

I've made sure there's some testing of the queries made in the web pages. We don't yet have any end-to-end template tests.

@marksteward
Copy link
Contributor Author

icalendar now supports VTIMEZONEs as of 24th March, so this could be easily added now.

So when they say "fully supported in icalendar for serialization and deserialization" they mean "if you create a Timezone object with all the necessary transitions", rather than exporting from pytz.

Full VTIMEZONE support moved to #19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant