-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make date/datetime types consistent #8
Comments
Should we also be ensuring we are TZ-aware throughout? |
Yes, but I'd like some more tests before we start that :) E.g. https://github.com/pubstandards/pubstandards-london/blob/master/tests/test_ps_data.py#L71 |
Argh, I wrote "timezones" on my notepad on the train and then forgot about it. Will do that tonight. |
TZ-awareness is #9, which is probably best sorted out before addressing this, as it also should include tests for starts/ends override. |
PSEvent should now consistently have the following attributes: .date is a datetime.date |
The algorithm generator creates PSEvents with date set to a datetime, while get_manual_ps_dates sets it to a date. Make these consistent and testable. Make sure overriding starts and ends in the json works too.
The text was updated successfully, but these errors were encountered: