Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the "we'll meet upstairs as usual" text #15

Open
marksteward opened this issue Mar 13, 2015 · 3 comments
Open

Fix the "we'll meet upstairs as usual" text #15

marksteward opened this issue Mar 13, 2015 · 3 comments

Comments

@marksteward
Copy link
Contributor

Remove it for Substandards, and correct it/hide it when the event's in the past.
@NeilCrosby NeilCrosby mentioned this issue Mar 13, 2015
Closed
@marksteward
Copy link
Contributor Author

OR MAYBE even have an extra field in the json that specifies additional directions.

@marksteward marksteward mentioned this issue Mar 30, 2015
Closed
@jaylett jaylett mentioned this issue Mar 24, 2016
Closed
@marksteward
Copy link
Contributor Author

Also, have a separate fallback if it's missing (per #24).

marksteward added a commit that referenced this issue Mar 27, 2016
@marksteward
Fix override attribute and default description
44c159a 
Rework constructor of PSEvents so that it always take a date, and
the override attribute is accurate. This allows us to compare two
PSEvents for equality and use .override in templates.

Fixes #8, #15 and #22
@marksteward
Copy link
Contributor Author

Not going to do anything fancy here - just remove the default description for overridden events, and events in the past.

@marksteward marksteward mentioned this issue Mar 27, 2016
Open
marksteward added a commit that referenced this issue Mar 27, 2016
@marksteward
Fix override attribute and default description
083b9b4 
Rework constructor of PSEvents so that it always take a date, and
the override attribute is accurate. This allows us to compare two
PSEvents for equality and use .override in templates.

Fixes #8, #15 and #22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marksteward