Create Downloadable Spreadsheet using SheetJS #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, this is very cool! What do you think, ready to merge? |
jywarren
reviewed
Jun 11, 2019
|
Isha, what do you think about this idea - could be discussed in a new issue - @publiclab-mimi was asking about saving data from https://webjack.io/examples/ -- to make it easy for students in a classroom to record sensor data from an Arduino, and visualize it. What about adding a button to WebJack that says "view this data in a graph" that opens an instance of Simple Data Grapher? |
|
That would be a pretty awesome idea. However, could you guide me a little
on how we could go about implementing this? This would be great to work on!
Also, yes this is ready for merge, it has a couple of debugging console.log
statements and I think one small little problem which don't affect the
SheetJS function, so if you could merge this, I could fix the small issues
in a follow up and Naman can also view them there. What do you think?
…On Wed, Jun 12, 2019, 4:32 AM Jeffrey Warren ***@***.***> wrote:
Isha, what do you think about this idea - could be discussed in a new
issue - @publiclab-mimi <https://github.com/publiclab-mimi> was asking
about saving data from https://webjack.io/examples/ -- to make it easy
for students in a classroom to record sensor data from an Arduino, and
visualize it. What about adding a button to WebJack that says "view this
data in a graph" that opens an instance of Simple Data Grapher?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#43?email_source=notifications&email_token=AJXHQZ5S5PBXTMSMFTFAWLTP2AVIRA5CNFSM4HXCT4TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXOX6FQ#issuecomment-501055254>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJXHQZ2MLNMYTVZDX2DBLDLP2AVIRANCNFSM4HXCT4TA>
.
|
IshaGupta18
commented
Jun 12, 2019
jywarren
reviewed
Jun 12, 2019
jywarren
reviewed
Jun 12, 2019
rexagod
requested changes
Jun 13, 2019
|
Hey thanks a lot! I just fixed this bug. Phewww.... But I will have to test
it a little before I can say for sure. I'll back to you if I face another
problem with this. Thank you!
…On Thu, Jun 13, 2019, 11:36 PM Pranshu Srivastava ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In dist/transpiled_code/View.js
<#43 (comment)>
:
> + continue;
+ }
+
+ var dataHash = Papa.parse(csv_string[i], {
+ dynamicTyping: true,
+ comments: true
+ });
+ mat[i] = dataHash['data'][0];
+ }
+
+ this.csvFile = mat;
+
+ document.getElementById(this.uploadButtonId).onclick = function (e) {
+ console.log("i am uploading");
+ console.log(this);
+ this.csvParser = new _CsvParser.CsvParser(this.csvFile, this.elementId, "csvstring");
So I guess the problem here is that new _CsvParser isn't getting changed
to new _CsvParser2? If so, would you mind doing a rename of this object
to anything other than its original returned variable name?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#43?email_source=notifications&email_token=AJXHQZ4BLLJZ7EKULFN76EDP2KEBRA5CNFSM4HXCT4TKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3PVE2I#pullrequestreview-249516649>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJXHQZ4ZWZ7DF36QGSKRJDTP2KEBRANCNFSM4HXCT4TA>
.
|
|
Sure, no problem! |
|
Hey @jywarren I have finally resolved #45 with @rexagod 's help and #44 is also resolved now. Apart from this, I have implemented all the 4 parsing functions, namely Remote, Local, Google Sheet and String file upload. I have also implemented the "save as image" function for every graph and save as spreadsheet for the data imported. Besides this, I have fixed some other small bugs and tried to modularize the code further. I know this is a bug PR, but its ready for merging. What do you think? |
Closed
|
Wow, amazing! Let me read through -- has @namangupta01 taken a look over it as well? |
jywarren
reviewed
Jun 18, 2019
|
I think he will be okay with it! He is been keeping a little busy these
days.
…On Tue, Jun 18, 2019, 7:38 PM Jeffrey Warren ***@***.***> wrote:
Wow, amazing! Let me read through -- has @namangupta01
<https://github.com/namangupta01> taken a look over it as well?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#43?email_source=notifications&email_token=AJXHQZ7IQOI7QLNBKSKRW4TP3DT5XA5CNFSM4HXCT4TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX6X3EA#issuecomment-503152016>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJXHQZZV73H2AMOBF4TX2P3P3DT5XANCNFSM4HXCT4TA>
.
|
|
I have deliberately left them for now, will be needing it in debugging.
Once we are a little more confident with our code, I'll get rid of them.
Does that sound right?
…On Tue, Jun 18, 2019, 7:39 PM Jeffrey Warren ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In dist/transpiled_code/View.js
<#43 (comment)>
:
> };
}
}
+ }, {
+ key: "handleFileSelectstring",
+ value: function handleFileSelectstring(val) {
+ console.log("i am at csv string handler");
Oops watch the comments here! Maybe remove? Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#43?email_source=notifications&email_token=AJXHQZ5DYDF6P5ORW2IMBKLP3DUCNA5CNFSM4HXCT4TKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB335OYI#pullrequestreview-251123553>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJXHQZ72BNL3OGPPB23SNXDP3DUCNANCNFSM4HXCT4TA>
.
|
jywarren
reviewed
Jun 18, 2019
jywarren
approved these changes
Jun 18, 2019
|
Yayy, thank you!!
…On Tue, Jun 18, 2019, 7:41 PM Jeffrey Warren ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#43?email_source=notifications&email_token=AJXHQZ6DVPN2L4BCFDWAR6DP3DUKBA5CNFSM4HXCT4TKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB335ZSI#pullrequestreview-251124937>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJXHQZ3TUWZ7CFMAIKZDQN3P3DUKBANCNFSM4HXCT4TA>
.
|
|
:-) Hooray! |
IshaGupta18
added a commit
that referenced
this pull request
Aug 10, 2019
* Project Setup (#5) * PublicLab Grapher Project Setup * Added Jquery, Papaparse and chart.js dependencies in package.json (#7) * Adding the parsing feature according to new project structure * Added npm run script to watch changes and added browserify package for build (#10) * Added Mocha testing framework and chai for assertion and added some sample test (#13) * Plotting Graphs using Chart.js (#18) * Sample data generation and table display * emptying tables * Plotting graph usingchart.js * checking file type through drag and drop and displaying alert on invalid type * removing inline function calling * little refactoring * showing checkboxes against valid columns only * Adding graphing menu for different graph types * adding colors to graph * plotting the whole data * Add files via upload * Adding CSV string import function (#28) * Adding CSV string import function * small fix * keeping up to date * Added Multiple graphs Feature (#29) * Basic Implementation of Class * Add implementation of different table generation * Added Multiple Menu For multiple graphs * Multiple Chart Generation Completed * Minor Changes * Divided into Diiferent files * Added Babel for transpiling es6 code and modularize code by movig classes to seperate files * Minor Bug Removed * Fixed Minor linting issues * Added Patch for Multiple Graphs (#36) Patch For Multiple Graph Bug * Update issue templates * Update issue templates * Update issue templates * Update issue templates * Update issue templates * Update README.md * Update README.md * Create CONTRIBUTING.md * Create CODE_OF_CONDUCT.md (#46) * Create PULL_REQUEST_TEMPLATE.md * Update issue templates * Adding ESlint (#37) * Create Downloadable Spreadsheet using SheetJS (#43) * Changes to src * More changes * remote url access * trying to pass remote values * SheetJS Complete * Resolved Bugs * All fixes! * Removing and adding some CDNs (font awesome addition and Range slider deletion) (#52) * Remove console.log's from View.js * changed the style of the button in View.js (#54) * [IMP] Added Tests, Refactored Code, Added Plotly.js and resolved some logical bugs (#59) * Shifting parsing code from View.js ro CsvParser.js * refactoring: adding return statements * Testing with refactored code * 1st test basic * resolving constrcutor error * Changing e=import and export syntax * try * Added Tests and corrected some code * ChartJs class * Plotly Class Added * Documentation for View and Csvparser functions (#61) * Added Installation Instruction (#62) * Update README.md * Gsheet (#63) * sign-in Google * attempt for google sheets * dummy credentials * ready to host on heroku * dummy * Update package.json * Update package.json * Update package.json * Bump lodash from 4.17.11 to 4.17.15 (#67) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.15. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.11...4.17.15) Signed-off-by: dependabot[bot] <[email protected]> * Update package.json * Update package-lock.json * Implementing CODAP export (#66) * updating package.json * heroku path * . * g sheet cred * sheet Functions * v1.0.4 * v1.0.5 * prev file use * view ma * latest V * Add file Description option to save against file * ids for popover fields * v1.2.1 * assigned title and desc * CODAP export * CODAP DONE * del creds * UI testing * v 1.3.2 * removing unused files * Delete test.csv * Delete uitest.js * UI Tests (#75) * updating package.json * heroku path * . * final tests1 * view changes
IshaGupta18
added a commit
that referenced
this pull request
Aug 20, 2019
* Project Setup (#5) * PublicLab Grapher Project Setup * Added Jquery, Papaparse and chart.js dependencies in package.json (#7) * Adding the parsing feature according to new project structure * Added npm run script to watch changes and added browserify package for build (#10) * Added Mocha testing framework and chai for assertion and added some sample test (#13) * Plotting Graphs using Chart.js (#18) * Sample data generation and table display * emptying tables * Plotting graph usingchart.js * checking file type through drag and drop and displaying alert on invalid type * removing inline function calling * little refactoring * showing checkboxes against valid columns only * Adding graphing menu for different graph types * adding colors to graph * plotting the whole data * Add files via upload * Adding CSV string import function (#28) * Adding CSV string import function * small fix * keeping up to date * Added Multiple graphs Feature (#29) * Basic Implementation of Class * Add implementation of different table generation * Added Multiple Menu For multiple graphs * Multiple Chart Generation Completed * Minor Changes * Divided into Diiferent files * Added Babel for transpiling es6 code and modularize code by movig classes to seperate files * Minor Bug Removed * Fixed Minor linting issues * Added Patch for Multiple Graphs (#36) Patch For Multiple Graph Bug * Update issue templates * Update issue templates * Update issue templates * Update issue templates * Update issue templates * Update README.md * Update README.md * Create CONTRIBUTING.md * Create CODE_OF_CONDUCT.md (#46) * Create PULL_REQUEST_TEMPLATE.md * Update issue templates * Adding ESlint (#37) * Create Downloadable Spreadsheet using SheetJS (#43) * Changes to src * More changes * remote url access * trying to pass remote values * SheetJS Complete * Resolved Bugs * All fixes! * Removing and adding some CDNs (font awesome addition and Range slider deletion) (#52) * Remove console.log's from View.js * changed the style of the button in View.js (#54) * [IMP] Added Tests, Refactored Code, Added Plotly.js and resolved some logical bugs (#59) * Shifting parsing code from View.js ro CsvParser.js * refactoring: adding return statements * Testing with refactored code * 1st test basic * resolving constrcutor error * Changing e=import and export syntax * try * Added Tests and corrected some code * ChartJs class * Plotly Class Added * Documentation for View and Csvparser functions (#61) * Added Installation Instruction (#62) * Update README.md * Gsheet (#63) * sign-in Google * attempt for google sheets * dummy credentials * ready to host on heroku * dummy * Update package.json * Update package.json * Update package.json * Bump lodash from 4.17.11 to 4.17.15 (#67) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.15. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.11...4.17.15) Signed-off-by: dependabot[bot] <[email protected]> * Update package.json * Update package-lock.json * Implementing CODAP export (#66) * updating package.json * heroku path * . * g sheet cred * sheet Functions * v1.0.4 * v1.0.5 * prev file use * view ma * latest V * Add file Description option to save against file * ids for popover fields * v1.2.1 * assigned title and desc * CODAP export * CODAP DONE * del creds * UI testing * v 1.3.2 * removing unused files * Delete test.csv * Delete uitest.js * UI Tests (#75) * updating package.json * heroku path * . * final tests1 * view changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So here's the first of the export options I have implemented: The user can download his uploaded CSV data as an excel spreadsheet.
@jywarren what do you think of this? This is a one-click export option! #17
@namangupta01 @gauravano @IgorWilbert @Souravirus what do you think?