-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish Simple-Data-Grapher graphs as a Research Note on Public Lab #6102
Conversation
@cesswairimu could you please help me out with the travis problem here? I did try to update my schema but it didn't have effect here |
Hey @IshaGupta18 I guess you need to change the timestamp here |
@cesswairimu I am trying this one out, let's see if it works! Thanks a ton! |
Hi! I will reply longer soon, but just referencing how the existing graphing system was done, which I think is a bit different than here; https://github.com/publiclab/PublicLab.Editor/pull/137/files This uploaded a file and inserted an inline power tag into the node body in the database, not just in the edit template. But is that happening here too, by inserting it above the node body content? Does it work in both markdown and rich modes? |
Is this also integrated into #6113? Thanks! |
Yes, closing this one too!
…On Fri, Aug 16, 2019, 1:05 AM Jeffrey Warren ***@***.***> wrote:
Is this also integrated into #6113
<#6113>? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6102?email_source=notifications&email_token=AJXHQZ4DIIOHCFICYE5WKKLQEWVZPA5CNFSM4IJEMG5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4MY6AY#issuecomment-521768707>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJXHQZ2U2AC6CXAG3NYXRMLQEWVZPANCNFSM4IJEMG5A>
.
|
For issue publiclab/simple-data-grapher#65
This is the feature implementation for Publish as a Research Note feature
Here's it's working!
I would be explaining the flow in the README.md of SDG, but I have explained most of it in the issue above. I have tried to make bare minimum changes to the existing code, and only one
if-condition
ineditor_controller
andrich.html.erb
, apart from that, a standard flow is followed. This has been a pretty challenging and time taking implementation! I hope it looks good!@jywarren @namangupta01 @sagarpreet-chadha @gauravano please take a look!
PS: I would be fixing some of the linting in subsequent commits