Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump grunt-contrib-jasmine from 1.0.3 to 2.0.3 #168

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Dec 6, 2018

Bumps grunt-contrib-jasmine from 1.0.3 to 2.0.3.

Changelog

Sourced from grunt-contrib-jasmine's changelog.

v2.0.3:
date: 2018-11-14
changes:
- Fix security deps: lodash
- Build only should pass if the buildSpecrunner runs without error
v2.0.2:
date: 2018-08-13
changes:
- Fix noSandbox option.
- Fix startTime, and timing issues.

v2.0.1:
date: 2018-05-31
changes:
- Use the grunt current working directory to find the jasmine core.
- Implement options.version.
- Dependency updates.

v2.0.0:
date: 2018-05-19
changes:
- Switch from PhantomJS to Chrome Headless via Puppeteer

v1.1.0:
date: 2017-01-12
changes:
- adds tempDir option.
- locks jasmine version

Commits
  • 201bb2a Release v2.0.3
  • 9b18221 Upgrade npm dependencies
  • d0e2572 fix: build only should pass if the buildSpecrunner runs without error
  • 74855ed Update dependencies
  • d65dd20 v2.0.2
  • d7f652f Fix typo
  • 55a5f1f Wait for spec runner before larunching browser
  • 408a233 Set the startTime before calling sendMessage
  • a30f731 Create new optional 'noSandbox' option to launching Puppeteer with no-sandbox...
  • a88f31b Launching Puppeteer with no-sandbox arg.
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Dec 6, 2018
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/grunt-contrib-jasmine-2.0.3 branch 3 times, most recently from 99e22ed to 4139f9f Compare December 7, 2018 20:46
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/grunt-contrib-jasmine-2.0.3 branch from 4139f9f to b721d01 Compare December 16, 2018 00:31
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/grunt-contrib-jasmine-2.0.3 branch 4 times, most recently from 63eedb5 to 300b38a Compare January 1, 2019 21:54
@jywarren
Copy link
Member

jywarren commented Jan 1, 2019

@dependabot rebase

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/grunt-contrib-jasmine-2.0.3 branch from 300b38a to dcfa4fd Compare January 1, 2019 22:08
@jywarren
Copy link
Member

jywarren commented Jan 1, 2019

OK, looks like maybe a breaking change in how Jasmine tasks are formatted?

0.86s$ grunt jasmine
Loading "jasmine.js" tasks...ERROR
>> SyntaxError: missing ) after argument list

@jywarren
Copy link
Member

jywarren commented Jan 1, 2019

@dependabot rebase

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/grunt-contrib-jasmine-2.0.3 branch from 62e63f8 to b54eafe Compare January 1, 2019 22:31
@jywarren
Copy link
Member

jywarren commented Jan 1, 2019

Some guidance on upgrading to Jasmine 2.0 here:

Oh, oops. Here we're only updateing grunt-contrib-jasmine not jasmine itself. Disregard.

@jywarren
Copy link
Member

jywarren commented Jan 1, 2019

@jywarren
Copy link
Member

jywarren commented Jan 1, 2019

@jywarren
Copy link
Member

jywarren commented Jan 1, 2019

Also seeing:

> node install.js
/home/travis/build/publiclab/PublicLab.Editor/node_modules/puppeteer/install.js:86
let progressBar = null;
^^^
SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode

Maybe we need to include puppeteer in our .travis.yml configs?

@ghost ghost assigned jywarren Jan 1, 2019
@ghost ghost added the in progress label Jan 1, 2019
@jywarren
Copy link
Member

jywarren commented Jan 1, 2019

OK - lots of useful errors now. Deprecating Node v5 and v6, the other Travis tests now return more useful errors.

@jywarren
Copy link
Member

jywarren commented Jan 1, 2019

Mostly prob related to:

     Error: Fixture could not be loaded: spec/javascripts/fixtures/index.html (status: error, message: Failed to execute 'send' on 'XMLHttpRequest': Failed to load 'file:///home/travis/build/publiclab/PublicLab.Editor/spec/javascripts/fixtures/index.html?_=1546383838422'.) (1)

@jywarren
Copy link
Member

jywarren commented Jan 2, 2019

@rexagod I've addressed a LOT of the dependabot updates and am looking to fix this one before publishing a new patch level update to NPM (addressing much of #195 I hope) -- would you have any time to take a look here to see what's going on? Thank you!!!

@rexagod
Copy link
Member

rexagod commented Jan 25, 2019

@jywarren There are a number of issues (this, this and many more) regarding this particular package all over the internet (including those over at the inline-md-editor). I mean, sure, we can continue to debug or wait for the devs at grunt to come up with something, or maybe, if you're still interested in that gulp/webpack idea, we can stop spending our time here and consider that instead.

Both approaches are fine by me, but I was just concerned about the fact that this has stalled us for quite some time now, and would like to know your thoughts on the same.

@jywarren
Copy link
Member

jywarren commented May 7, 2019 via email

@dependabot-preview
Copy link
Contributor Author

A newer version of grunt-contrib-jasmine exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@dependabot-preview dependabot-preview bot changed the base branch from master to main June 16, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants