Virtual reservoir new implementation docs

[carolmcs]

close #298
close #299
close #301

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.56%. Comparing base (e2887f6) to head (5b5cb26).
Report is 53 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
+ Coverage   82.09%   82.56%   +0.47%     
==========================================
  Files         131      132       +1     
  Lines        9705     9956     +251     
==========================================
+ Hits         7967     8220     +253     
+ Misses       1738     1736       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[pedroripper]

[Copilot]

Pull Request Overview

This PR updates the virtual reservoir implementation by revising function calls in the mathematical model and refactoring documentation to clearly distinguish energy account definitions for virtual reservoirs. Key changes include:

• Removing the call to virtual_reservoir_energy_account! in the mathematical model.
• Updating the return behavior in update_virtual_reservoir_reference_multiplier! in the hydro supply utilities.
• Refining and expanding the documentation regarding virtual reservoir bids and energy account definitions.

Reviewed Changes

Copilot reviewed 7 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/mathematical_model.jl	Removed the call to virtual_reservoir_energy_account! possibly affecting energy updates.
src/hydro_supply_reference_curve_utils.jl	Changed from returning MOI.set’s return value to explicitly returning nothing.
docs/src/market_clearing_problem.md	Updated energy account documentation with corrected terminology.
docs/src/heuristic_bids_vr.md	Added new detailed documentation for heuristic bids in virtual reservoirs.
docs/src/heuristic_bids.md	Removed virtual reservoir bid details that have been moved to a separate document.
docs/src/bidding_formats.md	Enhanced documentation references to include the new virtual reservoir bids chapter.
docs/make.jl	Updated navigation structure to reflect the new documentation organization.

Comments suppressed due to low confidence (2)

src/hydro_supply_reference_curve_utils.jl:40

• Changing the function's return behavior by discarding MOI.set's return value in update_virtual_reservoir_reference_multiplier! could affect callers expecting a specific result. Confirm that this design change is intentional and update documentation accordingly.

    return nothing

src/mathematical_model.jl:808

• The removal of the virtual_reservoir_energy_account!(args...) call might lead to missing energy account updates. Please verify that this functionality is now handled elsewhere.

        virtual_reservoir_total_generation!(args...)

[pedroripper]

Esse $J^{VR}$ não tinha que ser $J_{VR}$ ?

[carolmcs]

@pedroripper Não, no market_clearing_problem.md definimos: J^{VR}: Set of virtual reservoirs.

[pedroripper]

Dual na restrição embaixo