Add-support-datetime-zone-info #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandr-andr
reviewed
Dec 3, 2024
chandr-andr
reviewed
Dec 3, 2024
chandr-andr
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have added support for converting Python datetime objects with timezone information (tzinfo) to Rust types.
Motivation and Context
This change was required to address the issue where Python's datetime objects with tzinfo were raising the exception:
psqlpy.exceptions.PyToRustValueMappingError: Can't convert value from python to rust type: Can not convert your datetime to rust type.
The original issue:
#100
By implementing this fix, the functionality now properly handles datetime values with timezone information, bridging the type conversion gap between Python and Rust.
How has this been tested?
The changes were tested using tox as per the project's contributor guidelines. Existing tests in test_value_converter.py were rerun to verify the fix.
Additionally, a new test case was added to cover the scenario of converting a datetime.datetime object with timezone information (e.g., tzinfo=zoneinfo.ZoneInfo(key='Asia/Jakarta')). The test passed successfully, confirming the issue has been resolved without introducing regression.
Types of changes
x Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Checklist
x My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.