Bug/6294 zero bytes files are chunked #6568
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See bug #6294 for original bug report.
This PR provides a possible fix for this, reverting the change in #2896.
The change in #2896 definitely causes some bad side effects, since not all web servers handle "chunked" transfer encoding (i.e. some don't handle it, some don't handle it well).
Problem demonstration
Given a simple bottle application:
And a simple requests script:
Working Scenario
Test script output:
Failing Scenario
Test script output:
The Original Issue
The change causing this problem in the first place was due to failing to upload data read from a subprocess pipe.
This patch adds a check to
super_len
that avoids returning length 0 for file handles that are not regular files.