fix: pass response (self) to ConnectionError constructor #6270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I can tell, this is the only internal construction of `ConnectionError` that doesn't include `request` or `response`. Part of improving typing for exceptions in requests: python/typeshed#8989
intgr
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
I'm not associated with requests in any way, but looks good to me and is a desirable change. (I also came here from python/typeshed#8989)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, this is the only internal construction of
ConnectionErrorthat doesn't includerequestorresponse.Part of improving typing for exceptions in requests: python/typeshed#8989