Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Alarm Info #1

Closed
pryorda opened this issue Jun 29, 2018 · 11 comments
Closed

Getting Alarm Info #1

pryorda opened this issue Jun 29, 2018 · 11 comments
Labels
enhancement New feature or request

Comments

@pryorda
Copy link
Owner

pryorda commented Jun 29, 2018

From @l11h on March 1, 2018 13:24

It would be great to get Alarm info for VM's / Hosts
For VM there is an overallStatus option which works but it would be great to write to a label which alarm was executed.
This way we can easily check if we need to deal with it or not / how many alarms there are for the VM

Copied from original issue: rverchere/vmware_exporter#35

@rmontenegroo
Copy link
Contributor

What kind of alarms are you referring to?
It is possible to get alarms like "Virtual machine CPU usage" and so.
And what is the main idea? Get those alarms and stick'em all together in a label like "alarms" ? Or each alarm is a individual label?
For example: Virtual machine CPU usage has an internal short description of alarm.VmCPUUsageAlarm, that would be informative, and maybe useful if appended to an label "alarms".
How does that sound to you?

@pryorda
Copy link
Owner Author

pryorda commented Apr 30, 2020

As long as this doesn't slow the process down or add 1000s of metrics I'm okay with it.

@rmontenegroo
Copy link
Contributor

I have not tested anything yet but I was thinking of creating two metrics of alarms count: one for red overall status and the second for yellow. There would be an extra label indicating the list of alarms set;
So it would be 2 more metrics with an extra field. And we could leave those metrics optional.
What do you think?
Brainstorming here. :-)

@pryorda
Copy link
Owner Author

pryorda commented May 2, 2020

I think it should be fine.

@alecorps
Copy link
Contributor

alecorps commented May 2, 2020

Hi, i feeling prometheus exporter is not the good tool to check alarms. On your example, i think it’s a better way to collect cpu usage, and configure an alert in prometheus or grafana to notify alert manager.

@rmontenegroo
Copy link
Contributor

rmontenegroo commented May 2, 2020 via email

@rmontenegroo
Copy link
Contributor

Please, take a look at

https://github.com/rmontenegroo/vmware_exporter/tree/alarm_info

I am a bit entangled with these git branches :D
For some reason, I can't PR to your mater right now.

@pryorda
Copy link
Owner Author

pryorda commented May 6, 2020

Hi, i feeling prometheus exporter is not the good tool to check alarms. On your example, i think it’s a better way to collect cpu usage, and configure an alert in prometheus or grafana to notify alert manager.

Hey, I dont think its good to collect all alarms rathers. Just the status that vms or hosts are in. Warn, Critical, Etc. I wanted to see where @rmontenegroo went with this

@pryorda
Copy link
Owner Author

pryorda commented May 6, 2020

Please, take a look at

https://github.com/rmontenegroo/vmware_exporter/tree/alarm_info

I am a bit entangled with these git branches :D
For some reason, I can't PR to your mater right now.

Try to reset your changes, stash them, rebase off of the current master, then apply your new changes. Don't force push until everything looks right.

@rmontenegroo
Copy link
Contributor

I think I got it now.

@pryorda
Copy link
Owner Author

pryorda commented Mar 11, 2021

Closing for inactivity. We have merged some alarm changes in so it should help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants