feat(AWS): Lightsail new service and checks #3919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3919 +/- ##
==========================================
+ Coverage 86.47% 86.54% +0.06%
==========================================
Files 771 777 +6
Lines 23971 24139 +168
==========================================
+ Hits 20728 20890 +162
- Misses 3243 3249 +6 ☔ View full report in Codecov by Sentry. |
the API calls are mocked
use dicts instead lists and use threads to audit resources
the addition of this new check delete the others two related with public access
github-actions
bot
added
the
github_actions
sergargar
reviewed
May 16, 2024
| ): | ||
| report.status = "PASS" | ||
| report.status_extended = ( | ||
| f"Instance '{instance.name}' has no public access" |
There was a problem hiding this comment.
Suggested change
| f"Instance '{instance.name}' has no public access" | |
| f"Instance '{instance.name}' is not publicly exposed." |
sergargar
reviewed
May 16, 2024
| report.resource_arn = arn_instance | ||
| report.resource_tags = instance.tags | ||
| report.status = "FAIL" | ||
| report.status_extended = f"Instance '{instance.name}' has public access" |
There was a problem hiding this comment.
Can you put the ports that are opened?
sergargar
reviewed
May 16, 2024
| report.status = "FAIL" | ||
| report.status_extended = f"Instance '{instance.name}' has public access" | ||
| if instance.public_ip == "" and not any( | ||
| port.access_type == "public" for port in instance.ports |
There was a problem hiding this comment.
I cannot see the attribute access_type in the Port class
There was a problem hiding this comment.
sergargar
reviewed
May 16, 2024
| if static_ip.is_attached: | ||
| report.status = "PASS" | ||
| report.status_extended = ( | ||
| f"Static IP '{static_ip.name}' is associated with any instance." |
There was a problem hiding this comment.
Can you put the instance that is attached to?
sergargar
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Include new AWS service
Lightsailwith checks:Description
This PR add new services, checks and respective unit tests.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.