fix(efs): change public EFS check metadata #3917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3917 +/- ##
==========================================
+ Coverage 86.38% 86.39% +0.01%
==========================================
Files 748 748
Lines 23295 23295
==========================================
+ Hits 20123 20126 +3
+ Misses 3172 3169 -3 ☔ View full report in Codecov by Sentry. |
jfagoagas
deleted the
3913-bug-efs_not_publicly_accessible-check-based-on-misunderstanding
branch
sergargar
added a commit
that referenced
this pull request
May 6, 2024
pedrooot
pushed a commit
that referenced
this pull request
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Speaking with AWS Support, they confirmed that the EFS would only be accessed to any principal within the VPC not to the public internet. That is why, we have to change the metadata as well as the severity.
Thanks @rieck-srlabs for the catch!
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.