Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(v3): backport latest v4 changes #3916

Merged
merged 27 commits into from May 6, 2024
Merged

chore(v3): backport latest v4 changes #3916

merged 27 commits into from May 6, 2024

Conversation

sergargar
Copy link
Member

Description

Backport latest v4 changes.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

puchy22 and others added 15 commits May 3, 2024 10:38
@puchy22 @sergargar
test(gcp): Add new services tests to GCP (#3796)
27ea2d0 
Co-authored-by: Pepe Fagoaga <[email protected]>
@sergargar
fix(aws): not show findings when AccessDenieds (#3803)
5bda422
@sergargar
fix(metadata): remove semicolons from metadata texts (#3830)
0896c6b
@n4ch04 @sergargar
chore(regions_update): Changes in regions for AWS services. (#3848)
19cb5e3 
Co-authored-by: sergargar <[email protected]>
@sergargar @jfagoagas
chore(gcp): handle list projects API call errors (#3849)
13f8c85 
Co-authored-by: Pepe Fagoaga <[email protected]>
@n4ch04 @sergargar
chore(regions_update): Changes in regions for AWS services. (#3855)
7a07024 
Co-authored-by: sergargar <[email protected]>
@pedrooot @sergargar
fix(KeyError): handle CacheSubnetGroupName keyError (#3856)
c4bc406
@sergargar @puchy22
chore(docs): update BridgeCrew links in metadata to our local docs li…
9225b14 
…nk (#3858)

Co-authored-by: puchy22 <[email protected]>
@n4ch04 @sergargar
chore(regions_update): Changes in regions for AWS services. (#3862)
3b9d50b 
Co-authored-by: sergargar <[email protected]>
@sergargar
fix(efs): check all public conditions (#3872)
c5434cb
@puchy22 @sergargar
docs(unit-testing): Add GCP services documentation (#3901)
c885600
@sergargar
fix(vpc): solve subnet route key error (#3902)
8c65c94
@sergargar
fix(vpc): solve AWS principal key error (#3903)
a9f0cd7
@sergargar
fix(ec2): handle non-existing private ip (#3906)
3efd8f9
@n4ch04 @sergargar
chore(regions_update): Changes in regions for AWS services. (#3908)
9798be7 
Co-authored-by: sergargar <[email protected]>
@sergargar sergargar requested review from a team as code owners May 3, 2024 09:10
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024

You can check the documentation for this PR here -> SaaS Documentation

@github-actions github-actions bot added documentation provider/aws Issues/PRs related with the AWS provider provider/azure Issues/PRs related with the Azure provider provider/gcp Issues/PRs related with the Google Cloud Platform provider labels May 3, 2024
@jfagoagas
Copy link
Member

This PR requires to adapt all the providers thing in v4 to the audit_info in v3.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024

You can check the documentation for this PR here -> SaaS Documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024

You can check the documentation for this PR here -> SaaS Documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024

You can check the documentation for this PR here -> SaaS Documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024

You can check the documentation for this PR here -> SaaS Documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024

You can check the documentation for this PR here -> SaaS Documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024

You can check the documentation for this PR here -> SaaS Documentation

@codecov Codecov
Copy link

codecov bot commented May 3, 2024 •
edited

Codecov Report

Attention: Patch coverage is 86.94158% with 114 lines in your changes are missing coverage. Please review.

Project coverage is 86.81%. Comparing base (c2af649) to head (e0be579).
Report is 1 commits behind head on v3.

Files Patch % Lines
prowler/providers/aws/services/iam/iam_service.py 58.06% 26 Missing ⚠️
...ders/aws/services/cloudwatch/cloudwatch_service.py 51.61% 15 Missing ⚠️
...cy/iam_role_cross_account_readonlyaccess_policy.py 66.66% 11 Missing ⚠️
...ders/aws/services/cloudtrail/cloudtrail_service.py 46.66% 8 Missing ⚠️
...ces/resourceexplorer2/resourceexplorer2_service.py 22.22% 7 Missing ⚠️
...er/providers/aws/services/backup/backup_service.py 25.00% 6 Missing ⚠️
.../aws/services/ssmincidents/ssmincidents_service.py 0.00% 6 Missing ⚠️
prowler/providers/gcp/gcp_provider.py 0.00% 6 Missing ⚠️
.../providers/aws/services/account/account_service.py 44.44% 5 Missing ⚠️
...in_logs/cloudwatch_log_group_no_secrets_in_logs.py 89.47% 4 Missing ⚠️
... and 10 more
Additional details and impacted files 
@@            Coverage Diff             @@
##               v3    #3916      +/-   ##
==========================================
+ Coverage   85.96%   86.81%   +0.85%     
==========================================
  Files         706      712       +6     
  Lines       21854    22200     +346     
==========================================
+ Hits        18786    19274     +488     
+ Misses       3068     2926     -142

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

You can check the documentation for this PR here -> SaaS Documentation

jfagoagas
jfagoagas requested changes May 6, 2024
View reviewed changes
docs/developer-guide/unit-testing.md Outdated
):
# Instantiate an object of class with the mocked provider
bigquery_client = BigQuery(
set_mocked_gcp_provider(project_ids=[GCP_PROJECT_ID])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be audit_info, please review the docs pulled from v4 branch.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

prowler/lib/outputs/summary_table.py Outdated
@@ -40,11 +40,13 @@ def display_summary_table(
entity_type = "Project ID/s"
audited_entities = ", ".join(audit_info.project_ids)

if findings:
# Check if there are findings and that they are not all MANUAL
if findings and not all(finding.status == "MANUAL" for finding in findings):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is manual present in v4?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

prowler/lib/outputs/summary_table.py Outdated
current["Total"] = current["Critical"] = current["High"] = current[
"Medium"
] = current["Low"] = 0
current["Total"] = current["Pass"] = current["Muted"] = current[
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

muted is not present in v3.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

You can check the documentation for this PR here -> SaaS Documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

You can check the documentation for this PR here -> SaaS Documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

You can check the documentation for this PR here -> SaaS Documentation

@jfagoagas jfagoagas self-requested a review May 6, 2024 12:24
jfagoagas
jfagoagas approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @sergargar 👏

@sergargar sergargar merged commit 7954e61 into v3 May 6, 2024
12 checks passed
@sergargar sergargar deleted the release-3.16.4 branch May 6, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfagoagas jfagoagas jfagoagas approved these changes

Assignees
No one assigned
Labels
documentation provider/aws Issues/PRs related with the AWS provider provider/azure Issues/PRs related with the Azure provider provider/gcp Issues/PRs related with the Google Cloud Platform provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sergargar @jfagoagas @puchy22 @n4ch04 @pedrooot