fix(output): Handle case for None organizations metadata #3914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
This was referenced May 3, 2024
jfagoagas
requested changes
May 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3914 +/- ##
==========================================
- Coverage 86.40% 86.31% -0.10%
==========================================
Files 748 748
Lines 23295 23298 +3
==========================================
- Hits 20128 20109 -19
- Misses 3167 3189 +22 ☔ View full report in Codecov by Sentry. |
sergargar
previously approved these changes
May 3, 2024
jfagoagas
requested changes
May 6, 2024
| @@ -5,7 +5,7 @@ def unroll_list(listed_items: list, separator: str = "|"): | |||
| if not unrolled_items: | |||
| unrolled_items = f"{item}" | |||
| else: | |||
| unrolled_items = f"{unrolled_items} {separator} {item}" | |||
There was a problem hiding this comment.
I think we want to leave this for the | but not for the ,, could you please adapt it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #3909
Fixes #3897
Description
Organizations metadata were None in some cases. This issue was generating empty Prowler outputs but in this pr the problem is solved.
Thanks @jfagoagas for the help!
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.