chore(mitre gcp): add mitre mapping for gcp #3899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/gcp
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3899 +/- ##
=======================================
Coverage 86.32% 86.33%
=======================================
Files 748 748
Lines 23295 23323 +28
=======================================
+ Hits 20110 20135 +25
- Misses 3185 3188 +3 ☔ View full report in Codecov by Sentry. |
pedrooot
requested changes
Apr 30, 2024
| @@ -170,7 +188,7 @@ def fill_file_descriptors(output_modes, output_directory, output_filename, provi | |||
| file_descriptor = initialize_file_descriptor( | |||
| filename, | |||
| output_mode, | |||
| Check_Output_MITRE_ATTACK, | |||
| MitreAttackAWS, | |||
There was a problem hiding this comment.
elif provider.type == "azure": appears two times in this method, could you please unify them?
pedrooot
reviewed
Apr 30, 2024
| "network_ssh_internet_access_restricted", | ||
| "network_udp_internet_access_restricted", | ||
| "network_watcher_enabled", | ||
| "networkfirewall_in_all_vpc" |
There was a problem hiding this comment.
Suggested change
| "networkfirewall_in_all_vpc" |
"networkfirewall_in_all_vpc" it's not a check for azure
pedrooot
previously approved these changes
May 3, 2024
sergargar
reviewed
May 3, 2024
sergargar
previously approved these changes
May 3, 2024
sergargar
approved these changes
May 6, 2024
sergargar
deleted the
PRWLR-3579-oss-map-gcp-checks-to-mitre-att-ck-framework
branch
pedrooot
added a commit
that referenced
this pull request
May 15, 2024
Co-authored-by: pedrooot <[email protected]> Co-authored-by: Sergio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We need to cover mitre attack mapping for gcp
Description
Include mitre attack mapping for gcp
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.