chore(global_provider): Move methods to class as static #3896
Conversation
|
You can check the documentation for this PR here -> SaaS Documentation |
github-actions
bot
added
documentation
provider/aws
prowler/providers/common/models.py
Outdated
| @@ -38,8 +38,8 @@ def __init__(self, arguments, bulk_checks_metadata): | |||
| self.fixer = getattr(arguments, "fixer", None) | |||
|
|
|||
| # Shodan API Key | |||
| if arguments.shodan: | |||
| update_provider_config("shodan_api_key", arguments.shodan) | |||
| # if arguments.shodan: | |||
There was a problem hiding this comment.
Review this before merge.
| @@ -96,19 +95,6 @@ def check_current_version(): | |||
| return f"{prowler_version_string}" | |||
|
|
|||
|
|
|||
| # TODO: revisit this function | |||
There was a problem hiding this comment.
We cannot remove this function, it needs to be moved elsewhere.
|
You can check the documentation for this PR here -> SaaS Documentation |
|
You can check the documentation for this PR here -> SaaS Documentation |
|
You can check the documentation for this PR here -> SaaS Documentation |
|
You can check the documentation for this PR here -> SaaS Documentation |
|
You can check the documentation for this PR here -> SaaS Documentation |
|
You can check the documentation for this PR here -> SaaS Documentation |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3896 +/- ##
==========================================
- Coverage 86.65% 86.44% -0.22%
==========================================
Files 777 767 -10
Lines 24139 23891 -248
==========================================
- Hits 20918 20652 -266
- Misses 3221 3239 +18 ☔ View full report in Codecov by Sentry. |
|
You can check the documentation for this PR here -> SaaS Documentation |
|
You can check the documentation for this PR here -> SaaS Documentation |
…-provider-in-class
|
You can check the documentation for this PR here -> SaaS Documentation |
Description
Improve code organisation making the
set_global_providerandget_global_provider@staticmethod. This implies renaming a lot of code, which is already done and removes a file.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.