Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Control.Applicative warning #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MetaMemoryT
Copy link

since we depend on base >= 4.6 not going to support older versions
anyways.

since we depend on base >= 4.6 not going to support older versions
anyways.
@meteficha
Copy link
Member

I'm not sure what you mean but current esqueleto depends on base >= 4.5. Besides, base-4.6's Prelude doesn't export <$> AFAICS.

@MetaMemoryT
Copy link
Author

Oops I missed that. Guess I would need cpp to remove warning and be cross compatible.

@meteficha
Copy link
Member

AFAIU, <$> is exported by prelude only on base-4.8 (GHC 7.10).

@MetaMemoryT
Copy link
Author

Aha, I found a better solution than cpp.

Would you accept a PR that used base-compat? I would use the technique described here haskell-compat/base-compat#22 to solve Control.Applicative warnings.

@meteficha
Copy link
Member

I'm not sure. It's just a warning on the test suite, so adding a dependency seems a bit too heavy handed. Also, it doesn't look like any package related to esqueleto in some way uses it.

@snoyberg
Copy link
Contributor

I agree with @meteficha here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants