add liquid swap #65
Merged
add liquid swap #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This may have not fixed this entirely, because binance does not deliver the distribution histroy for swaps in the transaction log, this can be maybe be fixed with #59 or by querying the api with an api key also when the redemption does not happen in the currency that the add was, this also breaks ( 10 USD add, redemption 10BUSD for example) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #51
does not add support for defi lending only for liquid swap this should maybe be another issue
also currently binance classifies the rewards as "distribution" and we therefore as airdrop which im not quite sure is correct, the same goes for eth2 staking