Skip to content

feat: add device discover response #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

instpe
Copy link
Contributor

@instpe instpe commented Dec 11, 2024

feat: add device discover response

@instpe instpe force-pushed the add-device-discover-response branch from d0029ab to 2f4a6b7 Compare December 11, 2024 08:05
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 88.48921% with 16 lines in your changes missing coverage. Please review.

Project coverage is 87.68%. Comparing base (873945b) to head (0728bfd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../protocol/mdtp/common/model/CDATHeaderFactory.java 64.28% 4 Missing and 1 partial ⚠️
...a/io/github/protocol/mdtp/common/model/Device.java 90.24% 2 Missing and 2 partials ⚠️
...rotocol/mdtp/common/model/AbstractMessageBody.java 66.66% 2 Missing ⚠️
...p/common/codec/DeviceDiscoveryResponseDecoder.java 50.00% 1 Missing ⚠️
...col/mdtp/common/handler/MessageHandlerFactory.java 80.00% 1 Missing ⚠️
.../io/github/protocol/mdtp/common/model/Address.java 92.30% 0 Missing and 1 partial ⚠️
.../github/protocol/mdtp/common/model/Attributes.java 50.00% 1 Missing ⚠️
.../github/protocol/mdtp/common/model/CDATHeader.java 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #12      +/-   ##
============================================
- Coverage     87.91%   87.68%   -0.24%     
- Complexity       60       85      +25     
============================================
  Files            18       25       +7     
  Lines           240      341     +101     
  Branches         16       25       +9     
============================================
+ Hits            211      299      +88     
- Misses           17       28      +11     
- Partials         12       14       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@instpe instpe force-pushed the add-device-discover-response branch from 2f4a6b7 to 0728bfd Compare December 11, 2024 08:07
@hezhangjian hezhangjian merged commit d096616 into protocol-laboratory:main Dec 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants