-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rhel build issues #133
Conversation
@@ -156,6 +156,9 @@ if (MSVC) | |||
find_path(VCPKG_INCLUDE_DIR dirent.h) | |||
include_directories(${VCPKG_INCLUDE_DIR}) | |||
elseif (NOT ANDROID AND "${TARGET_PLATFORM}" STREQUAL "") | |||
# Needed when building with GCC < 9 | |||
link_libraries(stdc++fs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, not sure we want to keep this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is forward compatible with newer version of GCC and we don´t carry an if(my old compiler version) ...
, I'm fine with it 👌🏻 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
This pull request, with head sha This pull request will be automatically closed by GitHub.As soon as GitHub detects that the sha It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch |
No description provided.