Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rhel build issues #133

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Fix rhel build issues #133

merged 3 commits into from
Nov 21, 2024

Conversation

jthierry-psee
Copy link
Collaborator

No description provided.

@@ -156,6 +156,9 @@ if (MSVC)
find_path(VCPKG_INCLUDE_DIR dirent.h)
include_directories(${VCPKG_INCLUDE_DIR})
elseif (NOT ANDROID AND "${TARGET_PLATFORM}" STREQUAL "")
# Needed when building with GCC < 9
link_libraries(stdc++fs)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, not sure we want to keep this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is forward compatible with newer version of GCC and we don´t carry an if(my old compiler version) ... , I'm fine with it 👌🏻 !

Copy link
Collaborator

@ogeorget-psee ogeorget-psee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link

mergify bot commented Nov 21, 2024

This pull request, with head sha c783a075521005acff410463649afa519f08a55b, has been successfully merged with fast-forward by Mergify.

This pull request will be automatically closed by GitHub.

As soon as GitHub detects that the sha c783a075521005acff410463649afa519f08a55b is part of the main branch, it will mark this pull request as merged.

It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch fix-rhel-build-issues, this means GitHub will fail to detect the merge.

@mergify mergify bot merged commit c783a07 into main Nov 21, 2024
8 checks passed
@mergify mergify bot deleted the fix-rhel-build-issues branch November 21, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants