Skip to content

diskstats: add fallback to ID_SERIAL for virtio devices #3398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

diskstats: add fallback to ID_SERIAL for virtio devices #3398

wants to merge 1 commit into from

Conversation

illustris
Copy link

Virtio devices don't have ID_SERIAL_SHORT but do have ID_SERIAL. For example:

$ cat /run/udev/data/b253\:16
S:disk/by-id/virtio-data
S:disk/by-path/pci-0000:00:0b.0
S:disk/by-diskseq/2
S:disk/by-path/virtio-pci-0000:00:0b.0
E:ID_SERIAL=data
E:ID_PATH=pci-0000:00:0b.0
E:ID_PATH_TAG=pci-0000_00_0b_0
...
E:ID_PART_TABLE_TYPE=gpt
G:systemd
Q:systemd
V:1

This change adds a fallback to use ID_SERIAL when ID_SERIAL_SHORT is not available.

@illustris
diskstats: add fallback to ID_SERIAL for virtio devices
c22be9a 
Virtio devices don't have ID_SERIAL_SHORT but do have ID_SERIAL.
This change adds a fallback to use ID_SERIAL when ID_SERIAL_SHORT
is not available, allowing serial numbers to be properly exposed
for virtio block devices.

Also updates test expectations to reflect that devices with only
ID_SERIAL (like mmcblk devices in fixtures) now report their serial
numbers instead of empty strings.

Signed-off-by: illustris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@illustris