Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicated (+incorrect) metrics when using multiproc environment #960

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix duplicated (+incorrect) metrics when using multiproc environment #960

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1188f6a
fix multiproc bug
RedKinda Sep 20, 2023
e59f58e
unformat for PR purposes
RedKinda Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion prometheus_client/metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,10 @@ def __init__(self: T,

if not self._labelvalues:
# Register the multi-wrapper parent metric, or if a label-less metric, the whole shebang.
if registry:
if registry and not (
'prometheus_multiproc_dir' in os.environ
or 'PROMETHEUS_MULTIPROC_DIR' in os.environ
):
registry.register(self)

def labels(self: T, *labelvalues: Any, **labelkwargs: Any) -> T:
Expand Down