Fix flakes in tests using freeAddress
#4753
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses the following error:
freeAddressis called multiple times within one test, but also in parallel in multiple tests.freeAddressimmediately releases the port despite it being used later in a test. This causes ports to errorenously to be reused.We replace
net.Listenin order to avoid callingsyscall.Listen. This way the port can be reused by AM, without the kernel assuming that port can be reused by other processes specifiying port0.Fixes: #4742