Support http.Headers in util functions #3776
Open
+98
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the util functions such as PostJSON to support additional headers using http.Header. It will mean integrations such as RocketChat can use the notify functions instead of http.NewRequest. Signed-off-by: George Robinson <[email protected]>
Signed-off-by: George Robinson <[email protected]>
Signed-off-by: George Robinson <[email protected]>
grobinson-grafana
force-pushed
the
grobinson/support-http-headers-in-util
branch
from
239088b
to
24bf56c
Compare
zecke
reviewed
Apr 6, 2024
| @@ -164,7 +164,7 @@ func (n *Notifier) Notify(ctx context.Context, as ...*types.Alert) (bool, error) | |||
| u.RawQuery = parameters.Encode() | |||
| // Don't log the URL as it contains secret data (see #1825). | |||
| level.Debug(n.logger).Log("msg", "Sending message", "incident", key) | |||
| resp, err := notify.PostText(ctx, n.client, u.String(), nil) | |||
| resp, err := notify.PostText(ctx, n.client, u.String(), nil, nil) | |||
There was a problem hiding this comment.
That is a lot of "nil" for a caller. What if one just passes the *http.Request to a function like notify.Do?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the util functions such as PostJSON to support additional headers using http.Header. It will mean integrations such as RocketChat can use the notify functions instead of http.NewRequest.