[prometheus-sql-exporter] Initial release #4525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wilfried Roset <[email protected]>
monotek
requested changes
May 10, 2024
| apiVersion: v2 | ||
| description: Prometheus SQL Exporter | ||
| name: prometheus-sql-exporter | ||
| version: 1.0.0 |
There was a problem hiding this comment.
Suggested change
| version: 1.0.0 | |
| version: 0.1.0 |
|
|
||
| ## Prerequisites | ||
|
|
||
| - Kubernetes 1.8+ with Beta APIs enabled |
There was a problem hiding this comment.
Ist this actually tested with 1.8?
Otherwise please use non eol version.
Signed-off-by: Wilfried Roset <[email protected]>
|
thank @monotek I've taken into account your feedbacks. |
Signed-off-by: Wilfried Roset <[email protected]>
monotek
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR introduces a chart for deploying sql_exporter
Which issue this PR fixes
N/A
Special notes for your reviewer
I've purposedly choose to use @justwatchcom which is actively maintained instead of free/sql_exporter
Checklist
[prometheus-couchdb-exporter])