Improve error logging for unresolved variables#4447
Draft
RamanaReddy0M wants to merge 4 commits intodevfrom
Draft
Improve error logging for unresolved variables#4447RamanaReddy0M wants to merge 4 commits intodevfrom
RamanaReddy0M wants to merge 4 commits intodevfrom
Conversation
Member
There was a problem hiding this comment.
implementation lgtm !
$ ./nuclei -t ~/nuclei-templates/http/token-spray -v
__ _
____ __ _______/ /__ (_)
/ __ \/ / / / ___/ / _ \/ /
/ / / / /_/ / /__/ / __/ /
/_/ /_/\__,_/\___/_/\___/_/ v3.1.0-dev
projectdiscovery.io
[VER] Started metrics server at localhost:9092
[INF] Current nuclei version: v3.1.0-dev (outdated)
[INF] Current nuclei-templates version: v9.7.1 (latest)
[WRN] Scan results upload to cloud is disabled.
[INF] New templates added in latest release: 0
[INF] Templates loaded for current scan: 242
[INF] Executing 242 signed templates from projectdiscovery/nuclei-templates
[WRN] Failed 242 requests due to unresolved variables. Use -elabel=UNV to enable unresolved variables logs.
[INF] No results found. Better luck next time!Notes:
I think we can change statement since this is expected behaviour and not a error
since unresolved behaviour normally happens when template did not match or required variable like password,username was not provided from user
[WRN] Failed 242 requests due to unresolved variables. Use -elabel=UNV to enable unresolved variables logs.
something like
[VER] Skipped 242 Requests due to missing variable in input or request precondition failed due to no match in template
or even better we can seperate these two statements/cases
What do you think ?
cc: @ehsandeep @RamanaReddy0M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
test
Checklist