CORE-11514: Add CI test to check Calico images availability #10604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
skoryk-oleksandr
added
docs-not-required
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new CI step that verifies all required Calico images (excluding FIPS variants) are available in the operator release and manifests.
- Introduces
hack/check-images-availability.shto fetch image lists and test registry availability withcrane. - Hooks the new script into the
ci-preflight-checkstarget in the Makefile. - Ensures
bin/yqis built before running the image-check step.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| hack/check-images-availability.sh | New script to gather images from operator and manifests and verify availability with crane. |
| Makefile | Added check-images-availability target and wired it into ci-preflight-checks. |
Comments suppressed due to low confidence (1)
hack/check-images-availability.sh:11
- [nitpick] The variable name
defaultOperatorVersionuses camelCase, while other variables use uppercase with underscores. Consider renaming it toDEFAULT_OPERATOR_VERSIONordefault_operator_versionfor consistency.
defaultOperatorVersion=$("$YQ" .tigeraOperator.version < "${SCRIPT_DIR}/../charts/tigera-operator/values.yaml")
9abc1a0 to
e2f5941
Compare
skoryk-oleksandr
force-pushed
the
oleks-add-check-images-availability-test
branch
7 times, most recently
from
1561b16 to
447adcb
Compare
hjiawei
reviewed
Jul 1, 2025
Comment on lines
+1266
to
+1270
| $(eval TMP := $(shell mktemp -d)) | ||
| curl -sSfL --retry 5 -o $(TMP)/crane.tar.gz $(CRANE_URL) | ||
| tar -xzf $(TMP)/crane.tar.gz -C $(TMP) crane | ||
| mv $(TMP)/crane bin/crane | ||
| chmod +x bin/crane |
There was a problem hiding this comment.
The following one-liner downlads and extracts the crane binary from the release tarball.
curl -sSLf https://github.com/google/go-containerregistry/releases/download/${CONTAINERREGISTRY_VERSION}/go-containerregistry_Linux_x86_64.tar.gz | tar -xz -C bin/craneThe executable permission is retained from the archive, so there's no need to manually set it with chmod +x.
skoryk-oleksandr
force-pushed
the
oleks-add-check-images-availability-test
branch
4 times, most recently
from
dc0d1a6 to
c0105a7
Compare
skoryk-oleksandr
force-pushed
the
oleks-add-check-images-availability-test
branch
17 times, most recently
from
c31e9a2 to
bf9581f
Compare
skoryk-oleksandr
force-pushed
the
oleks-add-check-images-availability-test
branch
from
bf9581f to
4d09237
Compare
marvin-tigera
removed
docs-not-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TBD
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.