Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ldap): allow to customize user filter #2927

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

vooon
Copy link
Contributor

@vooon vooon commented Jan 30, 2025

What type of PR is this?

feature

Which issue does this PR fix:

Fix #2924

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.04%. Comparing base (05823cd) to head (bdbd282).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2927      +/-   ##
==========================================
+ Coverage   91.02%   91.04%   +0.02%     
==========================================
  Files         174      174              
  Lines       32636    32644       +8     
==========================================
+ Hits        29707    29722      +15     
+ Misses       2215     2209       -6     
+ Partials      714      713       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vooon vooon marked this pull request as ready for review January 31, 2025 09:02
@vooon vooon requested a review from rchincha as a code owner January 31, 2025 09:02
@vooon
Copy link
Contributor Author

vooon commented Jan 31, 2025

Tested with (&(objectClass=inetorgperson)(!(nsaccountlock=TRUE))(!(userClass=Bot))) - works as expected:

  • Zot's DN (bot) can't login anymore,
  • Normal user - can.

@andaaron
Copy link
Contributor

@vooon, please sign the commit.

@vooon
Copy link
Contributor Author

vooon commented Jan 31, 2025

@andaaron done.

@andaaron andaaron enabled auto-merge (squash) January 31, 2025 15:13
@andaaron andaaron merged commit 4fcd107 into project-zot:main Jan 31, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: LDAP user filter
2 participants