Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cve): expand search domain to cve description and package info #2086

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

laurentiuNiculae
Copy link
Contributor

What type of PR is this?

Which issue does this PR fix:
#1998

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e59d8da) 92.03% compared to head (1325b98) 92.00%.

Files Patch % Lines
pkg/extensions/search/cve/cve.go 44.44% 3 Missing and 2 partials ⚠️
pkg/extensions/search/cve/trivy/scanner.go 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2086      +/-   ##
==========================================
- Coverage   92.03%   92.00%   -0.04%     
==========================================
  Files         165      165              
  Lines       28336    28362      +26     
==========================================
+ Hits        26080    26094      +14     
- Misses       1666     1674       +8     
- Partials      590      594       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laurentiuNiculae laurentiuNiculae force-pushed the cve-update-search branch 2 times, most recently from fd13b68 to ac962f1 Compare November 29, 2023 12:52
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andaaron andaaron merged commit 90d27ff into project-zot:main Nov 29, 2023
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants