Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): add scheduler related metrics #2076

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

adodon2go
Copy link
Collaborator

What type of PR is this?
feature

Which issue does this PR fix:
#1870

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@adodon2go adodon2go force-pushed the scheduler-task-metric branch 3 times, most recently from 3df9853 to 7365037 Compare November 24, 2023 18:01
@adodon2go adodon2go marked this pull request as ready for review November 24, 2023 18:01
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (c62ca62) 92.00% compared to head (2e0ecc4) 92.04%.

Files Patch % Lines
pkg/api/cookiestore.go 0.00% 5 Missing ⚠️
pkg/extensions/imagetrust/image_trust.go 66.66% 2 Missing ⚠️
pkg/extensions/scrub/scrub.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2076      +/-   ##
==========================================
+ Coverage   92.00%   92.04%   +0.03%     
==========================================
  Files         165      165              
  Lines       28362    28615     +253     
==========================================
+ Hits        26094    26338     +244     
- Misses       1674     1683       +9     
  Partials      594      594              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/scheduler/scheduler.go Outdated Show resolved Hide resolved
pkg/scheduler/scheduler.go Outdated Show resolved Hide resolved
pkg/scheduler/scheduler.go Outdated Show resolved Hide resolved
pkg/scheduler/scheduler.go Show resolved Hide resolved
pkg/scheduler/scheduler.go Outdated Show resolved Hide resolved
pkg/scheduler/scheduler.go Outdated Show resolved Hide resolved
pkg/scheduler/scheduler.go Show resolved Hide resolved
pkg/api/cookiestore.go Show resolved Hide resolved
@adodon2go adodon2go force-pushed the scheduler-task-metric branch 5 times, most recently from e0a4e4a to 90fbbdc Compare November 29, 2023 18:12
@adodon2go adodon2go force-pushed the scheduler-task-metric branch from 90fbbdc to 2e0ecc4 Compare December 4, 2023 17:33
@rchincha rchincha merged commit 2e733b3 into project-zot:main Dec 4, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: add a metric (prometheus) to track how many tasks in our scheduler queue
3 participants