test(lint): refactor logs and add linting rules #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentiuNiculae
force-pushed
the
ram-log-refactor
branch
2 times, most recently
from
38de96b to
d9e774a
Compare
|
Think about this pattern ... pkg/log/constants.go const RepoNotFoundMsg = "repo not found" log.Info().Msg(RepoNotFoundMsg) |
|
Error msgs ... to be standardized. "Failed to ..." "Failed to <verb>" All strings in msgs should be lowercase and not LOWERCASE Str("component", component).Msg("...") |
|
Add a log linter if possible. |
laurentiuNiculae
force-pushed
the
ram-log-refactor
branch
3 times, most recently
from
eab9675 to
7612d2e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2045 +/- ##
==========================================
- Coverage 92.06% 92.00% -0.06%
==========================================
Files 165 165
Lines 28623 28687 +64
==========================================
+ Hits 26352 26394 +42
- Misses 1678 1697 +19
- Partials 593 596 +3 ☔ View full report in Codecov by Sentry. |
laurentiuNiculae
force-pushed
the
ram-log-refactor
branch
from
7612d2e to
4840afd
Compare
laurentiuNiculae
requested review from
adodon2go,
eusebiu-constantin-petu-dbk,
Andreea-Lupu,
shimish2,
rchincha and
andaaron
as code owners
laurentiuNiculae
force-pushed
the
ram-log-refactor
branch
5 times, most recently
from
19726ff to
e89b043
Compare
laurentiuNiculae
force-pushed
the
ram-log-refactor
branch
5 times, most recently
from
8c707a9 to
ecf44e1
Compare
laurentiuNiculae
force-pushed
the
ram-log-refactor
branch
from
f96e892 to
9c8aacb
Compare
laurentiuNiculae
force-pushed
the
ram-log-refactor
branch
3 times, most recently
from
c134a4a to
9df9fc5
Compare
|
I have added 2 linting rules for now:
|
andaaron
reviewed
Nov 27, 2023
andaaron
reviewed
Nov 27, 2023
laurentiuNiculae
force-pushed
the
ram-log-refactor
branch
4 times, most recently
from
457c132 to
57aef9f
Compare
andaaron
reviewed
Nov 28, 2023
andaaron
reviewed
Nov 28, 2023
laurentiuNiculae
force-pushed
the
ram-log-refactor
branch
5 times, most recently
from
5768ee6 to
c5adc1f
Compare
andaaron
force-pushed
the
ram-log-refactor
branch
4 times, most recently
from
3b8dfc4 to
85914c9
Compare
Signed-off-by: Ramkumar Chinchani <[email protected]> Signed-off-by: Laurentiu Niculae <[email protected]> Signed-off-by: Andrei Aaron <[email protected]>
andaaron
force-pushed
the
ram-log-refactor
branch
from
85914c9 to
363fe94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.