feat(ldap): add option to load ldap from file #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentiuNiculae
requested review from
rchincha,
andaaron and
eusebiu-constantin-petu-dbk
as code owners
rchincha
reviewed
Sep 8, 2023
laurentiuNiculae
force-pushed
the
ldap-from-file
branch
from
c2ce4c8 to
69cfba5
Compare
andaaron
reviewed
Sep 11, 2023
andaaron
reviewed
Sep 11, 2023
laurentiuNiculae
force-pushed
the
ldap-from-file
branch
6 times, most recently
from
142cd5a to
425f21a
Compare
Codecov Report
@@ Coverage Diff @@
## main #1778 +/- ##
==========================================
+ Coverage 91.97% 92.06% +0.08%
==========================================
Files 164 164
Lines 27657 27716 +59
==========================================
+ Hits 25437 25516 +79
+ Misses 1645 1629 -16
+ Partials 575 571 -4
... and 3 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
laurentiuNiculae
force-pushed
the
ldap-from-file
branch
5 times, most recently
from
1742024 to
187ddfa
Compare
rchincha
reviewed
Sep 15, 2023
rchincha
reviewed
Sep 15, 2023
laurentiuNiculae
force-pushed
the
ldap-from-file
branch
6 times, most recently
from
75dc5c9 to
9064df6
Compare
laurentiuNiculae
force-pushed
the
ldap-from-file
branch
3 times, most recently
from
d3cbacc to
0e65d80
Compare
rchincha
reviewed
Nov 3, 2023
rchincha
reviewed
Nov 3, 2023
laurentiuNiculae
force-pushed
the
ldap-from-file
branch
4 times, most recently
from
9554599 to
d90dee5
Compare
|
Can you also add an example configuration file? |
laurentiuNiculae
force-pushed
the
ldap-from-file
branch
6 times, most recently
from
dc45dd2 to
0a3ee8f
Compare
andaaron
reviewed
Nov 9, 2023
laurentiuNiculae
force-pushed
the
ldap-from-file
branch
2 times, most recently
from
3ec666d to
015c18c
Compare
andaaron
reviewed
Nov 10, 2023
laurentiuNiculae
force-pushed
the
ldap-from-file
branch
4 times, most recently
from
63c4cac to
361c06a
Compare
Signed-off-by: Laurentiu Niculae <[email protected]>
laurentiuNiculae
force-pushed
the
ldap-from-file
branch
from
361c06a to
618e771
Compare
andaaron
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.