Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add error validation for update all #618

Merged

Conversation

ashnamehrotra
Copy link
Contributor

merge after #570

Describe the changes in this pull request using active verbs such as Add, Remove, Replace ...

Closes #593

Part of #522

Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
@ashnamehrotra ashnamehrotra changed the title Feat: Add error validation for update all feat: Add error validation for update all May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 50 lines in your changes missing coverage. Please review.

Project coverage is 33.59%. Comparing base (2602d59) to head (20a3290).
Report is 90 commits behind head on main.

Files Patch % Lines
pkg/pkgmgr/rpm.go 0.00% 21 Missing ⚠️
pkg/pkgmgr/dpkg.go 0.00% 20 Missing ⚠️
pkg/pkgmgr/apk.go 0.00% 7 Missing ⚠️
pkg/buildkit/buildkit.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #618      +/-   ##
==========================================
+ Coverage   32.51%   33.59%   +1.08%     
==========================================
  Files          17       18       +1     
  Lines        1621     1551      -70     
==========================================
- Hits          527      521       -6     
+ Misses       1062      997      -65     
- Partials       32       33       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
@ashnamehrotra ashnamehrotra marked this pull request as ready for review June 12, 2024 22:04
@ashnamehrotra
Copy link
Contributor Author

tested this with hardcoding, added followup issue (#660) to add end to end testing as discussed

pkg/pkgmgr/apk.go Outdated Show resolved Hide resolved
pkg/pkgmgr/rpm.go Outdated Show resolved Hide resolved
pkg/pkgmgr/rpm.go Outdated Show resolved Hide resolved
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@ashnamehrotra ashnamehrotra merged commit 938c98b into project-copacetic:main Jun 26, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants