Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forceful deletion of remaining pods after cleanup #670

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

metalcycling
Copy link
Collaborator

Issue link

#599

What changes have been made

This version of the code allows users to provide a termination time that MCAD will use to wait before it forcefully deletes any remaining pods in the system. A cleanup is done first like it has always been done, but if there are still pods left after the wait time, they are forcefully deleted.

Verification steps

Ran code with AppWrapped pods that have a long terminationGracePeriodSeconds and triggered preemption by deleting one of the pods so minAvailable is violated. Before requeuing, this version deletes ALL pods that are not cleaned up.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from metalcycling. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant