Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stress Tests MCAD using KWOK #469

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

vishakha-ramani
Copy link

Dispatch performance of MCAD with many small jobs

The following experiment was performed to understand the overhead associated with MCAD, if any, when large number of small AW jobs, consisting ony of 1 pod, are inserted into a system. To do that, we use KWOK toolkit that enables us to simulate the lifecycle of fake nodes, pods and other Kubernetes API resources.

@Sara-KS
Copy link
Contributor

Sara-KS commented Jul 11, 2023

Thanks for the PR @vishakha-ramani ! @z103cb it looks like the Travis build is failing, can you point us to any of the Travis CI output? My view only shows limited information on why it failed.

@Sara-KS
Copy link
Contributor

Sara-KS commented Jul 11, 2023

@asm582 Can you review this PR? Also, does the MCAD repo follow the practices of squashing commits before a merge into main?

@asm582
Copy link
Member

asm582 commented Jul 11, 2023

Thanks for the PR @vishakha-ramani ! @z103cb it looks like the Travis build is failing, can you point us to any of the Travis CI output? My view only shows limited information on why it failed.

The build failed in quota management which is not related to this PR, I have restarted the build

Copy link
Member

@asm582 asm582 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, most scripts use the same base template and run different kinds of experiments, can we create a single script for running different kinds of experiments? Also, I have provided a few comments on the markdown file.

@@ -0,0 +1,160 @@
## MCAD GPU Request Performance test with KWOK
This experiment assumes that you have a KWOK controller as well as MCAD controller running inside a kind cluster. If not, follow [this](https://github.com/vishakha-ramani/multi-cluster-app-dispatcher/blob/main/test/perf-test/simulatingnodesandappwrappers.md) for installation instructions.
The MCAD service for gpu requests is little weird . Here is the experiment I did and what I observed:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for gpu requests is little weird can we change the wording and give the user a little more insight into the use case we ought to test, please?

...
```

7. The pod is scheduled to one of the fake nodes (which theoretically it shouldn't).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, did we ever print a histogram inside MCAD and see how it looks? also, can we mention which version of MCAD was used for testing?

@z103cb
Copy link
Contributor

z103cb commented Jul 12, 2023

Thanks for the PR @vishakha-ramani ! @z103cb it looks like the Travis build is failing, can you point us to any of the Travis CI output? My view only shows limited information on why it failed.

@Sara-KS,
It's the normal flakiness of the MCAD tests. Merging main, should improve the situation, but we still have outstanding bugs related to why MCAD is failing. We can merge this work as is as it doesn't effect anything in the build. We should probably integrate this work into the normal build at some point.

@z103cb
Copy link
Contributor

z103cb commented Jul 12, 2023

@asm582 Can you review this PR? Also, does the MCAD repo follow the practices of squashing commits before a merge into main?

I believe they are squashed. @asm582 can you confirm ?

@Sara-KS
Copy link
Contributor

Sara-KS commented Jul 12, 2023

@z103cb Thank you for the feedback! We can plan on integrating this work into the build.

@asm582
Copy link
Member

asm582 commented Jul 12, 2023

@asm582 Can you review this PR? Also, does the MCAD repo follow the practices of squashing commits before a merge into main?

I believe they are squashed. @asm582 can you confirm ?

Yes, they are squashed

@openshift-ci
Copy link

openshift-ci bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign metalcycling for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

values:
- kwok
# A taints was added to an automatically created Node.
# You can remove taints of Node or add this tolerations.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# You can remove taints of Node or add this tolerations.
# You can remove the taint on the node or add this toleration.
  • A single taint was added to the node. A taint contains a list, but only one is specified here.
  • A single toleration is added to the job. A toleration contains a list, but only one is specified here.

operator: In
values:
- kwok
# A taints was added to an automatically created Node.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# A taints was added to an automatically created Node.
# A taint was added automatically to the created Node.

Though the node was created automatically in the shell script at Line 21, the taint was also added automatically.

```
For example, for this job spec, the timestamps captured are `creationTimestamp: "2023-08-03T13:07:27Z"` and `completionTime: "2023-08-03T13:09:52Z"`. The job completion time is then just `completionTime - creationTimestamp`.

3. Dispatch Time: The interval between AppWrapper creation time and dispatch time

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Dispatch Time: The interval between AppWrapper creation time and dispatch time
3. Dispatch Time: The interval between AppWrapper creation time and dispatch time.

I added a period to show that the sentence has ended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants