Update pde names. #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename 4p1a into pitch_E (case1 and case2) and 4p2 into pitch_C. Tests have been added for pitch_E case 2.
max_level was not high enough (7) so I put it to 8. It was triggering assert: Error using md_idx_to_lev_pos (line 22) not sure why this doesnt work, but just increase max_lev Update all generated inputs until bug: Generating gold data for coefficients component Not enough input arguments. Error in fokkerplanck2_complete (line 51) params = fokkerplanck_parameters(opts); Error in gold_coefficients (line 3) generate_data( fokkerplanck2_complete, levels, 'fokkerplanck2_complete', 'deg', 3 ); Error in make_all_gold (line 27) gold_coefficients
13 tasks
|
It is mandatory to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename 4p1a into pitch_E and 4p2 into pitch_C.
TODO:
() Test gold_pde.m (issue #63 #53 #39
() there is no test for pitch_E case 2.