Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pde names. #65

Open
wants to merge 3 commits into
base: reference
Choose a base branch
from
Open

Conversation

hbrunie
Copy link

@hbrunie hbrunie commented Jan 19, 2021

Rename 4p1a into pitch_E and 4p2 into pitch_C.
TODO:
() Test gold_pde.m (issue #63 #53 #39
(
) there is no test for pitch_E case 2.

@hbrunie
Copy link
Author

hbrunie commented Jan 19, 2021

TODO:
() Test gold_pde.m (issue #63 #53 #39
(
) there is no test for pitch_E case 2.

Rename 4p1a into pitch_E (case1 and case2) and 4p2 into pitch_C.
 Tests have been added for pitch_E case 2.
max_level was not high enough (7) so I put it to 8.
It was triggering assert:
Error using md_idx_to_lev_pos (line 22)
not sure why this doesnt work, but just increase max_lev
Update all generated inputs until bug:

Generating gold data for coefficients component
Not enough input arguments.

Error in fokkerplanck2_complete (line 51)
params = fokkerplanck_parameters(opts);

Error in gold_coefficients (line 3)
generate_data( fokkerplanck2_complete, levels, 'fokkerplanck2_complete', 'deg', 3 );

Error in make_all_gold (line 27)
gold_coefficients
@hbrunie
Copy link
Author

hbrunie commented Jan 25, 2021

It is mandatory to add fokkerplanck_pitch_E_case2 coefficients and time_advance generated files, so that these tests can be executed and this PR can pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant