refactor: replace time-based polling with Chatwoot builtin event #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the time-based polling mechanism with a Chatwoot builtin event
listener for detecting readiness. Introduced `isReady` and `waitForReady`
utility to ensure Chatwoot API calls are made only after initialization
This also fixes an occasional bug where `observer.value.observe` fails
with `TypeError: Failed to execute 'observe' on 'MutationObserver':
parameter 1 is not of type 'Node'`. The error occurred because
`document.querySelector('.woot-widget-holder')` sometimes returned
`null`, causing `startObserver` to initialize with an invalid node.
gustavosbarreto
force-pushed
the
refactor/chatwoot-ready-event
branch
from
fa85a37 to
4291235
Compare
|
Thank you ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced the time-based polling mechanism with a Chatwoot builtin event listener for detecting readiness. Introduced
isReadyandwaitForReadyutility to ensure Chatwoot API calls are made only after initializationAdditional context
This also fixes an occasional bug where
observer.value.observefails withTypeError: Failed to execute 'observe' on 'MutationObserver': parameter 1 is not of type 'Node'. The error occurred becausedocument.querySelector('.woot-widget-holder')sometimes returnednull, causingstartObserverto initialize with an invalid node.