Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added describe to directional light and color variable example #447

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

yogitheboss
Copy link
Contributor

this addresses issue #312

Copy link
Collaborator

@SableRaf SableRaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @yogitheboss, thank you for your contribution! The text content of the describe() function is great.

We kindly request that you add the describe() function to the liveSketch.js examples rather than the .pde files. You can find an explanation here. The describe() function is only available in p5.js, not in Processing. The purpose of this change is to ensure that interactive examples are properly described for users who rely on screen readers.

Please don't hesitate to ask if you have any questions or concerns. Thank you again for your valuable contribution!

void setup() {

describe('there are two dark spheres side by side ,the cursor works like a light source ,when mouse moves the direction of light changes and reveals some part of spheres.')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comma placement: a light source ,when -> a light source, when

@yogitheboss
Copy link
Contributor Author

Ok @SableRaf , now i got it.
I should have checked the readme file.
I will make the necessary changes and submit the pull request again.

@SableRaf
Copy link
Collaborator

Hey @yogitheboss,

Just checking in on the describe() changes for the liveSketch.js examples. Noticed it's been a while since we last touched base on this. When you get a chance, could you update and resubmit the PR? Let me know if you need any help.

Thanks!

Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for processing-faf822 ready!

Name Link
🔨 Latest commit f32e706
🔍 Latest deploy log https://app.netlify.com/sites/processing-faf822/deploys/65bd05ac2c59780007ce3a6b
😎 Deploy Preview https://deploy-preview-447--processing-faf822.netlify.app/examples/saturation
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants