fix: attach save() to p5.Graphics.prototype #8881#8886
Closed
BHARATH0153 wants to merge 2 commits into
Closed
Conversation
Author
|
@perminder-17 @davepagurek please review and run the checks |
Member
|
Hi! Unfortunately we'll close your currently open PRs without merging. Although you've been asked multiple times to follow contributor guidelines and wait for assignment before filing PRs, you have ignored this. If you make further PRs before you've been assigned, we may temporarily suspend your account. The reason of the guidelines is to help manage review workload, so while we understand many people are waiting for review, that is exactly why making PRs without assignment can make the wait times longer overall. Thanks for understanding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8881
Changes
Fixed
save()not working onp5.GraphicsPreviously
save()was only attached top5.prototypevia thefilesmodule (registered throughp5.registerAddon), sopg.save("test.png")threwTypeError: pg.save is not a function.Now the
filesmodule is also called withp5.Graphics.prototypeinside thegraphics()registration function, following the exact same pattern as all other modules (primitives2D,attributes,image,pixels, etc.).PR Checklist