Skip to content

fix: attach save() to p5.Graphics.prototype #8881#8886

Closed
BHARATH0153 wants to merge 2 commits into
processing:mainfrom
BHARATH0153:fix/graphics-save
Closed

fix: attach save() to p5.Graphics.prototype #8881#8886
BHARATH0153 wants to merge 2 commits into
processing:mainfrom
BHARATH0153:fix/graphics-save

Conversation

@BHARATH0153

@BHARATH0153 BHARATH0153 commented Jun 9, 2026

Copy link
Copy Markdown

Resolves #8881

Changes

Fixed save() not working on p5.Graphics

Previously save() was only attached to p5.prototype via the files module (registered through p5.registerAddon), so pg.save("test.png") threw TypeError: pg.save is not a function.

Now the files module is also called with p5.Graphics.prototype inside the graphics() registration function, following the exact same pattern as all other modules (primitives2D, attributes, image, pixels, etc.).

PR Checklist

  • npm run lint passes
  • Inline reference is included / updated
  • Unit tests are included / updated

@BHARATH0153

BHARATH0153 commented Jun 9, 2026

Copy link
Copy Markdown
Author

@perminder-17 @davepagurek please review and run the checks

@ksen0

ksen0 commented Jun 15, 2026

Copy link
Copy Markdown
Member

Hi! Unfortunately we'll close your currently open PRs without merging. Although you've been asked multiple times to follow contributor guidelines and wait for assignment before filing PRs, you have ignored this. If you make further PRs before you've been assigned, we may temporarily suspend your account. The reason of the guidelines is to help manage review workload, so while we understand many people are waiting for review, that is exactly why making PRs without assignment can make the wait times longer overall. Thanks for understanding.

@ksen0 ksen0 closed this Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[p5.js 2.0+ Bug Report]:save() not working on graphics

2 participants