Update creating addon libraries contributor docs #7800
Conversation
| }; | ||
| function loadCSVAddon(p5, fn, lifecycles){ | ||
|
|
||
| } |
There was a problem hiding this comment.
Do you think it's worth adding, after this, the code to register the addon?
if (typeof p5 !== undefined) {
p5.registerAddon(loadCSVAddon);
}We don't always do this immediately in internal addons, but if the goal is to package an addon externally, we'd probably expect this in there too.
There was a problem hiding this comment.
Yeah I probably should include that. I was planning to do an edit to include ESM usage as well, I think I'll do that in this round too so that there's more complete context on the design.
There was a problem hiding this comment.
Do you think it's worth adding, after this, the code to register the addon?
if (typeof p5 !== undefined) { p5.registerAddon(loadCSVAddon); }We don't always do this immediately in internal addons, but if the goal is to package an addon externally, we'd probably expect this in there too.
Yes, that should be great to include.
There was a problem hiding this comment.
Hi @limzykenneth , the docs for the 2.0 on creating addon library looks great to me.
I was planning to do an edit to include ESM usage as well
I would love to see these as well :). thanks for your work
|
Just added an additional section for @davepagurek @perminder-17 Do have a look if you have the time. |
Addresses #7798
Changes:
Update the creating addon libraries contributor docs to use the new addon API. It still does not include all the new features and nuanced details yet but that can be added later, this PR is mainly to get information up to date. I'll be updating the other contributor docs accordingly as well but in separate PRs.