Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7056 (but don't merge this until after #6761 is merged!)
Changes
This branches off of #6761, which is ready to merge, but will be merged after our final docs release today so that we have time to beta test more thoroughly before doing a release. In the mean time, the actual diff can be seen here: deveshidwivedi/p5.js@model-view...davepagurek:p5.js:switch-camera-keep-transform
But to summarize:
setCamera
updates the view matrix in addition to the projection matrixcamera()
no longer resets the model matrix, just the view matrixNow, a
resetMatrix()
is no longer required after usingsetCamera
in a framebuffer'sbegin
/end
: https://editor.p5js.org/davepagurek/sketches/k71F1YPDpPR Checklist
npm run lint
passes