Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference fixes #349

Merged
merged 5 commits into from May 12, 2024
Merged

Reference fixes #349

merged 5 commits into from May 12, 2024

Conversation

davepagurek
Copy link
Collaborator

@davepagurek davepagurek commented May 10, 2024

Resolves #344

A few fixes here:

  • p5.Image methods are no longer duplicated under the "Image" category. The problem here was that they are both class methods and also have a submodule in their metadata. I now filter out all class methods in subcategories to avoid these showing up in two spots.

    image

  • blend() no longer links to the BLEND docs. The issue here is that there used to be a naming clash between constants and methods. This has since been corrected (constants go in a constants/ folder), but since Git by default doesn't commit changes to case in files, the blend() method still exists in a file called BLEND.mdx, making its Astro entry id clash with the one in the constants folder. If you use git mv, then git will finally acknowledge case changes, so I've renamed all of those to lowercase and routing seems to work again:

    image

    image

  • Parameters no longer repeat items that are shared across multiple overloads

  • Parameter types are included in the description again:

    image

  • Puts back rich formatting in class methods/descriptions. I think this may have been confusing in the designs because in the Figma, most rich formatting is gone, but I think that may be because it was tedious for the designers to copy it all over. Since there are still some instances of rich formatting in this spot in the Figma and we have it on the current site too, I'm putting it back, but with more condensed paragraph spacing to make it look more close to the designs.

    image

@davepagurek davepagurek merged commit 3fbb30f into main May 12, 2024
4 checks passed
@davepagurek davepagurek deleted the fix/reference branch May 12, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On the reference page, p5.Image methods are duplicated
1 participant