Improving build performance #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@outofambit If you'd like to have a look at this to make sure things are not broken. |
|
@limzykenneth i tried this out locally and seems great. the build time on this PR's CI run sure is short :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #340
Three of the most time consuming functions are now memoized using
lodash/memoizewhich significantly pared down the build time for reference and sketches. For dev server the behavior does not seem to be affected as there seem to be a server restart on content changes, ie. updating content (including translation) will trigger a content refresh with updated content.In addition, the image service used by Astro on build is switched to using
passthroughImageServiceas it is doing duplicate task ofastro-compress. Passing through speed things up slightly from a clean build and just letastro-compressdo its thing.