Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Close file options drowndown when clicking outside (Issue #3332) #3333

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

kammeows
Copy link
Contributor

@kammeows kammeows commented Feb 5, 2025

Fixes #3332

Changes: In the file named FileNode.jsx, I have updated the following button component:
<button
className="sidebar__file-item-show-options"
aria-label={t('FileNode.ToggleFileOptionsARIA')}
ref={fileOptionsRef}
tabIndex="0"
onClick={toggleFileOptions}
onBlur={() => setTimeout(hideFileOptions, 200)}
>

The change is the addition of the line: onBlur={() => setTimeout(hideFileOptions, 200)}

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for raising this issue and working on this!

I think this solution seems good to me so far. Although you've already met all the requirements, one thing I might note is to just confirm that you've reviewed the checklist within our pull request template! Thanks so much again!

@raclim raclim merged commit 2f99876 into processing:develop Feb 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File options dropdown remains open when clicking other files
2 participants