Allow recursive folder addition of executables (closes #379) #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot. |
omergoktas
pushed a commit
to omergoktas/linuxdeployqt
that referenced
this pull request
Oct 12, 2024
…probonopd#596) * Allow recursive folder addition of executables (closes probonopd#379) * Remove mention of Bintray --------- Co-authored-by: probonopd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for making linuxdeployqt available.
The issue referenced is rather old and the current solution used in the inkscape packaging (using a
forloop in shell scripting) might be all needed.This patch adds a
-executable-dircommand-line that adds all files in a folder, recursively.Supporting wildcards might need additional dependencies and doesn't seem worth making the code more complex.
Note: the build instructions reference to an AppImage on bintray.com that is no longer available. It might be worth posting an alternative someplace else. It builds find with system Qt Creator.