Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for JSON response to /light/n/state commands #88

Merged
merged 11 commits into from
Oct 23, 2017

Conversation

Quanghoster
Copy link
Contributor

addSingleLightJson added with correct structure for response.
Also see comments in #62

Quanghoster and others added 11 commits October 19, 2017 21:54
Trying to update my fork
Added AddSingleLightJson method which corrects a json structure issue when the amazon echo tries to discover what lights are present.
Adjusted case of "urn:schemas-upnp-org:device:basic:1" references as to what has been observed on the network
@probonopd probonopd merged commit b072276 into probonopd:master Oct 23, 2017
@dtila
Copy link
Contributor

dtila commented Oct 30, 2017

Correct me if I am wrong, but from the merge result b072276 I see just you added a new function AddSingleLightJson, where it's a copy paste of the existing addLightJson. The functionality is the same, even less, since it does not respect the DIMMABLE_LIGHT functionality which I have added in a previous commit.

Am I mistaken ?

@Quanghoster
Copy link
Contributor Author

Quanghoster commented Oct 30, 2017 via email

@dtila
Copy link
Contributor

dtila commented Oct 30, 2017

Do you have an example of the built JSON ?
I am curios how is it different (except the color arguments which they were expected).

Just looking at the code, I could deduce that Alexa does not have support for Dimmable Light, so it thinks that the JSON is invalid. I don't have an Alexa to check, but it looks strange ...

@Quanghoster
Copy link
Contributor Author

Quanghoster commented Oct 30, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants