-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alexa discovery updates #87
Conversation
Trying to update my fork
Added AddSingleLightJson method which corrects a json structure issue when the amazon echo tries to discover what lights are present. Adjusted case of "urn:schemas-upnp-org:device:basic:1" references as to what has been observed on the network
Hi @Quanghoster . This pull request overrides mine #85 If you revert your changes and merge from master, you will be able to see the hue by Alexa. I can say that since I had an Alexa meanwhile |
Hmm, strange. I thought I have brought.my fork up to date with your repository before I tested it with alexa and it didn't work for me last night. Github is confusing On 20 Oct 2017 08:51, Daniel <[email protected]> wrote:Hi @Quanghoster . This pull request overrides mine #85
If you revert your changes and merge from master, you will be able to see the hue by Alexa. I can say that since I had an Alexa meanwhile
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.
|
You can see 6c63513#diff-e15aea686d057abe4787cdfd553060f8R1040 . Along with your suggestions, I added support for dimmable light. Have a look at the link, and make a comparison please. |
Ok, I must have completed the fork sync incorrectly. I'm managed to get it in sync and it now works without modification. Thanks 👍 |
So how should we proceed with this PR? |
We should cancel this one, however that is done. However, I don't think the code is quite right still. The master now does discover correctly but I don't think is correctly responding to the echo turn on and off requests, which I had also fixed in my repository. I need to check the cause of that over the next couple of days, when I can fit it in. I think that may be the reason for the json format change I added in this PR On 21 Oct 2017 10:05, probonopd <[email protected]> wrote:So how should we proceed with this PR?
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.
|
If I find the issue I will post an updated PR with the change On 21 Oct 2017 10:58, Andy Dennis <[email protected]> wrote:We should cancel this one, however that is done. However, I don't think the code is quite right still. The master now does discover correctly but I don't think is correctly responding to the echo turn on and off requests, which I had also fixed in my repository. I need to check the cause of that over the next couple of days, when I can fit it in. I think that may be the reason for the json format change I added in this PR On 21 Oct 2017 10:05, probonopd <[email protected]> wrote:So how should we proceed with this PR?
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.
|
Closing this PR as suggested by @Quanghoster. Please open a new one. Thanks. |
Once I have figured this part out I'll put some time in to spiffs On 21 Oct 2017 11:16, Andy Dennis <[email protected]> wrote:If I find the issue I will post an updated PR with the change On 21 Oct 2017 10:58, Andy Dennis <[email protected]> wrote:We should cancel this one, however that is done. However, I don't think the code is quite right still. The master now does discover correctly but I don't think is correctly responding to the echo turn on and off requests, which I had also fixed in my repository. I need to check the cause of that over the next couple of days, when I can fit it in. I think that may be the reason for the json format change I added in this PR On 21 Oct 2017 10:05, probonopd <[email protected]> wrote:So how should we proceed with this PR?
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.
|
I@ve just synchronised my fork and noticed that the Alexa discovery was still not working in the main repository. I've included the necessary changes to correct this, namely a new function that formats the returned json to alexa on discovery and corrected the case of one of the SSDP attributes, as observed on the network