-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compliation issues #121
Conversation
Fixes #120 |
|
Also, we should fix the very commit of each library using |
Sorry, I forgot to mention that I included ESPAsyncUDP library from https://github.com/me-no-dev/ESPAsyncUDP manually, because it doesn't seem to be included in https://github.com/esp8266/Arduino. So in my lib folder I now have aJson, ESPAsyncUDP, NtpClient and Time. |
There's still a problem with the flush() function of aJson that I only fixed locally. Working on it now. Edit: https://gitlab.com/xarduino/lightsw/blob/master/patch/ajson-void-flush.patch |
My last commit should have done the trick for ESP8266HueEmulator.ino, but I can't get the Json-Example to compile. aJson seems not to be supported anymore and the example is not crucial to this project in my opinion. |
Please review your PR, I think you have added too many files (including aJSON). |
Sorry, major f***up. This commit was not planned to go into the PR at all and should only be in my fork. I guess I wasn't thinking quite straight anymore last night. I'll move the last commits to a separate branch as soon as I come home tonight and hope this will fix it. |
Reset origin/master to the correct commit and created branch platformio for my additional changes. I promise to use separate branches for PRs in the future, I'm just not really used to the workflow, yet. |
Looking better, now we need to make it build... |
Skipping the Json_Example.ino now, but the travis build just stops after the aJson example sketches. I guess that's not the expected behaviour. Does it make sense to build all *.ino files (including examples from libraries), or would it be better to call the arduino build for the main sketch as in the WirelessPrinting repo? |
I'd say the main sketch is sufficient, what do you think? |
build_platform was called in wrong directory
Finally found the time to fix the remaining issues after only eight months (sory about that). |
Thank you very much @Solmath |
Due to changes in various dependencies (ESP8266core, NeoPixelBus) the project wouldn't compile using platformIO. Also some minor issues that resulted in compiler warnings were fixed.