Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compliation issues #121

Merged
merged 11 commits into from
Dec 23, 2019
Merged

Fix compliation issues #121

merged 11 commits into from
Dec 23, 2019

Conversation

Solmath
Copy link
Contributor

@Solmath Solmath commented May 5, 2019

Due to changes in various dependencies (ESP8266core, NeoPixelBus) the project wouldn't compile using platformIO. Also some minor issues that resulted in compiler warnings were fixed.

@Solmath
Copy link
Contributor Author

Solmath commented May 5, 2019

Fixes #120

@probonopd
Copy link
Owner

In file included from /home/travis/build/probonopd/ESP8266HueEmulator/ESP8266HueEmulator/ESP8266HueEmulator.ino:11:0:
/home/travis/arduino_ide/libraries/NtpClient/src/NtpClientLib.h:105:25: fatal error: ESPAsyncUDP.h: No such file or directory
 #include <ESPAsyncUDP.h>

@probonopd
Copy link
Owner

Also, we should fix the very commit of each library using git clone -o <hash> in .travis.yml so that things don't break again when libraries change over time. Like we do in https://github.com/probonopd/WirelessPrinting/blob/master/.travis.yml.

@Solmath
Copy link
Contributor Author

Solmath commented May 5, 2019

In file included from /home/travis/build/probonopd/ESP8266HueEmulator/ESP8266HueEmulator/ESP8266HueEmulator.ino:11:0:
/home/travis/arduino_ide/libraries/NtpClient/src/NtpClientLib.h:105:25: fatal error: ESPAsyncUDP.h: No such file or directory
 #include <ESPAsyncUDP.h>

Sorry, I forgot to mention that I included ESPAsyncUDP library from https://github.com/me-no-dev/ESPAsyncUDP manually, because it doesn't seem to be included in https://github.com/esp8266/Arduino.

So in my lib folder I now have aJson, ESPAsyncUDP, NtpClient and Time.

@Solmath
Copy link
Contributor Author

Solmath commented May 5, 2019

There's still a problem with the flush() function of aJson that I only fixed locally. Working on it now.

Edit: https://gitlab.com/xarduino/lightsw/blob/master/patch/ajson-void-flush.patch

@Solmath
Copy link
Contributor Author

Solmath commented May 5, 2019

My last commit should have done the trick for ESP8266HueEmulator.ino, but I can't get the Json-Example to compile.

aJson seems not to be supported anymore and the example is not crucial to this project in my opinion.

@probonopd
Copy link
Owner

Please review your PR, I think you have added too many files (including aJSON).

@Solmath
Copy link
Contributor Author

Solmath commented May 6, 2019

Sorry, major f***up. This commit was not planned to go into the PR at all and should only be in my fork. I guess I wasn't thinking quite straight anymore last night.

I'll move the last commits to a separate branch as soon as I come home tonight and hope this will fix it.

@Solmath
Copy link
Contributor Author

Solmath commented May 6, 2019

Reset origin/master to the correct commit and created branch platformio for my additional changes.

I promise to use separate branches for PRs in the future, I'm just not really used to the workflow, yet.

@probonopd
Copy link
Owner

Looking better, now we need to make it build...

@Solmath
Copy link
Contributor Author

Solmath commented May 7, 2019

Skipping the Json_Example.ino now, but the travis build just stops after the aJson example sketches. I guess that's not the expected behaviour.

Does it make sense to build all *.ino files (including examples from libraries), or would it be better to call the arduino build for the main sketch as in the WirelessPrinting repo?

@probonopd
Copy link
Owner

I'd say the main sketch is sufficient, what do you think?

@Solmath
Copy link
Contributor Author

Solmath commented Dec 20, 2019

Finally found the time to fix the remaining issues after only eight months (sory about that).

@probonopd
Copy link
Owner

Thank you very much @Solmath

@probonopd probonopd merged commit a891e52 into probonopd:master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants