Remove library modification requirements and bring in features #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the requirement to modify the aJson library to get a larger buffer. The default method allocates a buffer for rendering JSON dynamically based on output size. A new method has also been added for applications with less available SRAM (setBufferlessResponses). This requires no large fixed or dynamic buffer, but increases response rendering time by close to two orders of magnitude due to inefficiencies and overhead in the WiFiClient and aJson. With the following PR in place, this is reduced to an order of magnitude difference (50ms vs 400ms for /api): interactive-matter/aJson#91
This allows for more customized code later on by clients.
This displays the MAC on boot.
This adds support for reading and responding to incoming NOTIFYs.
This allows for beginning a SEARCH and handling SEARCH responses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the requirement to modify the aJson library. I have a pull request open against aJson to make bufferless run faster, but it's unlikely to get merged since the person managing the project seems to have abandoned it. Bufferless responses currently causes the code to run unreasonably slow due to the missing optimizations in aJson, but even with them is still slower than the current situation or dynamic buffer. This is due to the large amount of overhead that exists in the HTTP client library when writing data to it piecemeal and the optimizations partially address that by reducing the number of calls into the HTTP client library when possible.
The modifications to SSDP are features that will enable more fun things I have in the pipe, but are completely backward compatible with existing usage.